Update shared example to support pip/conda lib #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanglaser
requested review from
ahuber21,
dian-lun-lin and
ibhati
as code owners
ethanglaser
requested review from
Copilot
and removed request for
ahuber21,
dian-lun-lin and
ibhati
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the shared C++ examples to support multiple installation methods for the SVS library, specifically adding support for pip and conda packages alongside the existing tarball release method. The changes simplify the workflow when using pip/conda installations by automatically detecting installed packages and falling back to tarball download when needed.
Key changes:
- Added automatic detection of system/conda/pip SVS installations before downloading tarball
- Updated documentation to include installation and usage instructions for conda and pip methods
- Simplified library linking by using CMake targets instead of manual library finding
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/cpp/shared/README.md | Added documentation for conda and pip installation methods with usage examples, reorganized content into three installation options |
| examples/cpp/shared/CMakeLists.txt | Implemented automatic SVS package detection with fallback to tarball download, updated library linking to use CMake targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mihaic
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.